Added styles props, bug fix input focus, and quick refactor#41
Open
JonatanGarciaClavo wants to merge 1 commit intotutorialhorizon:masterfrom
Open
Added styles props, bug fix input focus, and quick refactor#41JonatanGarciaClavo wants to merge 1 commit intotutorialhorizon:masterfrom
JonatanGarciaClavo wants to merge 1 commit intotutorialhorizon:masterfrom
Conversation
…s to inline styles, create new file with TagComponent, modify config and builds to support new TagComponent file. Bug fix, added missing this.refs.input.focus() on _handleClickOnWrapper, added tags as second param on every onRemoveTag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature, new props added to override styles, change all css styles to inline styles, create new file with TagComponent, modify config and builds to support new TagComponent file. Bug fix, added missing this.refs.input.focus() on _handleClickOnWrapper, added tags as second param on every onRemoveTag.
What it is missing?
Hover style is missing, Maybe it is time to use Radium(
https://github.com/FormidableLabs/radium)Another good idea could be transform all code from es5 to es6, more even if you have in mind grunt-react plugin it is deprecated(grunt-babel should be used instead of it)
Why I did this fork?
I have multiple themes in my app and at the moment I want to change styles of this project I can't do it unless I change css file, witch in my case it is imposible.
If you have any questions please let me know.
Regards.